Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: document experiment results ingestion #450

Merged
merged 8 commits into from
Oct 27, 2023
Merged

feat: document experiment results ingestion #450

merged 8 commits into from
Oct 27, 2023

Conversation

noctillion
Copy link
Contributor

This PR adds a workflow for document ingestion (pdf, csv, etc) as part of experiment results.

@codecov
Copy link

codecov bot commented Oct 26, 2023 •
edited
Loading

Codecov Report

Merging #450 (bccb03b) into develop (2817fd8) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           develop     #450   +/-   ##
========================================
  Coverage    88.12%   88.12%           
========================================
  Files          115      115           
  Lines         4310     4311    +1     
  Branches       559      559           
========================================
+ Hits          3798     3799    +1     
  Misses         364      364           
  Partials       148      148
Files Coverage Δ
chord_metadata_service/chord/workflows/metadata.py 100.00% <100.00%> (ø)
chord_metadata_service/experiments/schemas.py 100.00% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@davidlougheed davidlougheed changed the title Features/documents results ingestion feat: document experiment results ingestion Oct 26, 2023
@davidlougheed davidlougheed marked this pull request as ready for review October 26, 2023 20:42
davidlougheed
davidlougheed requested changes Oct 27, 2023
View reviewed changes
Copy link
Member

@davidlougheed davidlougheed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getting close! a couple last reqs

chord_metadata_service/chord/workflows/metadata.py Outdated Show resolved Hide resolved
chord_metadata_service/chord/workflows/wdls/document.wdl Outdated Show resolved Hide resolved
davidlougheed
davidlougheed approved these changes Oct 27, 2023
View reviewed changes
Copy link
Member

@davidlougheed davidlougheed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@noctillion noctillion merged commit c24e121 into develop Oct 27, 2023
7 checks passed
@davidlougheed davidlougheed deleted the features/documents-results-ingestion branch November 6, 2023 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidlougheed davidlougheed davidlougheed approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@noctillion @davidlougheed